[7269] bulk export history fails with client-assigned string IDs #7300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcaruso
requested review from
jamesagnew,
michaelabuckley and
tadgh
as code owners
Contributor
|
Formatting check succeeded! |
jdar8
reviewed
Oct 15, 2025
...ources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml
Outdated
Show resolved
Hide resolved
jdar8
reviewed
Oct 15, 2025
Collaborator
jdar8
left a comment
jdar8
left a comment
There was a problem hiding this comment.
Left a suggestion on the changelog. Other than that, looks good to me!
Requires a senior+ approval
…_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml Co-authored-by: jdar8 <[email protected]>
michaelabuckley
requested changes
Oct 15, 2025
hapi-fhir-jpaserver-test-r4/src/test/java/ca/uhn/fhir/jpa/bulk/BulkExportUseCaseTest.java
Show resolved
Hide resolved
...tch2-jobs/src/main/java/ca/uhn/fhir/batch2/jobs/export/ExpandResourceAndWriteBinaryStep.java
Outdated
Show resolved
Hide resolved
...ources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml
Show resolved
Hide resolved
michaelabuckley
approved these changes
Oct 23, 2025
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
* bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]>
hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java
Outdated
Show resolved
Hide resolved
…ex/IdHelperService.java Co-authored-by: Michael Buckley <[email protected]>
tadgh
deleted the
rc-20251010-bulk-export-fails-with-string-resource-ids
branch
fil512
pushed a commit
that referenced
this pull request
Nov 12, 2025
* increase memory to elastic search container (#7326) Co-authored-by: jdar <[email protected]> * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown (#7303) * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown. * Enhanced the solution based on code review feedback. * Removed a class that was being used to store the Http response Code and used the existing HttpStatus class instead. * Enhanced the Unit Test. * Enhanced the Javadoc for the Pointcut.SERVER_OUTGOING_FAILURE_OPERATIONOUTCOME enum. * Changed the Interceptor Hook implementation based on Code Review feedback. * Removed an unused variable declaration. * Removed an unused variable declaration. * Ran mvn spotless:apply to apply proper formatting. * More code review feedback. * Use ResponseDetails for exception outcome modification. * Remove bit about "valid status" -- we allow anything * changelog * Replace the response object --------- Co-authored-by: Michael Buckley <[email protected]> * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) (#7327) * Improve URL processing for JpaPersistedResourceValidationSupport (#7330) * Improve URL processing for JpaPersistedResourceValidationSupport * Add changelog * allow fetching subsequent pages when registering an allowed spec of r… (#7329) * allow fetching subsequent pages when registering an allowed spec of resourcetype search * 7833: add missing relationship between TermConcept and TermConceptProperty (#7346) * 7316 do not expand chain refparams (#7350) * Make sure refparams with chains are not expanded via MDM * 7316: code review feedback * [7269] bulk export history fails with client-assigned string IDs (#7300) * fixed 7269 bulk export history failure with client-assigned string IDs * fixed 7269 bulk export history failure with client-assigned string IDs * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml Co-authored-by: jdar8 <[email protected]> * changed string ids to IResourcePersistentId * changed string ids to IResourcePersistentId * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java Co-authored-by: Michael Buckley <[email protected]> * fixed with spotless * Revert "Bump to 8 7 (#7322)" This reverts commit 40f1128. * Revert "changed string ids to IResourcePersistentId" This reverts commit 06af86a. * Revert "batch2 jobs that are cancelled will not be returned when requesting a… (#7321)" This reverts commit be08680. * changed string ids to IResourcePersistentId * fixed with spotless * Bumped version number * adding missing change to fix build --------- Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jdar8 <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Michael Buckley <[email protected]> * [7332] fix mdm-query-links (#7356) * 7324 unable to access collection bundles when performing search requests (#7325) * Add failing tests * Fix * Changelog * Fix comment * Fix test * Try fixing CodeQL autobuild error * Implement revision suggestions * Add missed test case parameter * PatientIdPartitionIntercepto should allow Encounter.subject parameter (#7348) * Work on megascale enhancements part 6 * Add changelog * Test fix * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7348-allow-patientidcompartmentmode-search-encounter-subject.yaml Co-authored-by: Nathan Doef <[email protected]> * Test fixes --------- Co-authored-by: Nathan Doef <[email protected]> * Bump to spring62 (#7351) * Bump spring framework version * Replace Base64Utils with Base64.getEncoder() * Bump spring boot test deps to match spring version 6.2 * Bump junit for spring tests --------- Co-authored-by: Gary <[email protected]> * 7217 with rel 8 6 (#7337) * Automated Migration Testing (HAPI-FHIR) - updated test migration scripts for 8_6_0 (#7357) * Remove dead autowire (#7365) * Don't reuse TransactionDetails for partitioned TX execution (#7363) * Fix tags on megascale * Add test * Test fix * Version bump --------- Co-authored-by: jdar <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: James Agnew <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]>
jamesagnew
added a commit
that referenced
this pull request
Nov 20, 2025
* increase memory to elastic search container (#7326) Co-authored-by: jdar <[email protected]> * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown (#7303) * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown. * Enhanced the solution based on code review feedback. * Removed a class that was being used to store the Http response Code and used the existing HttpStatus class instead. * Enhanced the Unit Test. * Enhanced the Javadoc for the Pointcut.SERVER_OUTGOING_FAILURE_OPERATIONOUTCOME enum. * Changed the Interceptor Hook implementation based on Code Review feedback. * Removed an unused variable declaration. * Removed an unused variable declaration. * Ran mvn spotless:apply to apply proper formatting. * More code review feedback. * Use ResponseDetails for exception outcome modification. * Remove bit about "valid status" -- we allow anything * changelog * Replace the response object --------- Co-authored-by: Michael Buckley <[email protected]> * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) (#7327) * Improve URL processing for JpaPersistedResourceValidationSupport (#7330) * Improve URL processing for JpaPersistedResourceValidationSupport * Add changelog * allow fetching subsequent pages when registering an allowed spec of r… (#7329) * allow fetching subsequent pages when registering an allowed spec of resourcetype search * 7833: add missing relationship between TermConcept and TermConceptProperty (#7346) * 7316 do not expand chain refparams (#7350) * Make sure refparams with chains are not expanded via MDM * 7316: code review feedback * [7269] bulk export history fails with client-assigned string IDs (#7300) * fixed 7269 bulk export history failure with client-assigned string IDs * fixed 7269 bulk export history failure with client-assigned string IDs * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml Co-authored-by: jdar8 <[email protected]> * changed string ids to IResourcePersistentId * changed string ids to IResourcePersistentId * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java Co-authored-by: Michael Buckley <[email protected]> * fixed with spotless * Revert "Bump to 8 7 (#7322)" This reverts commit 40f1128. * Revert "changed string ids to IResourcePersistentId" This reverts commit 06af86a. * Revert "batch2 jobs that are cancelled will not be returned when requesting a… (#7321)" This reverts commit be08680. * changed string ids to IResourcePersistentId * fixed with spotless * Bumped version number * adding missing change to fix build --------- Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jdar8 <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Michael Buckley <[email protected]> * [7332] fix mdm-query-links (#7356) * 7324 unable to access collection bundles when performing search requests (#7325) * Add failing tests * Fix * Changelog * Fix comment * Fix test * Try fixing CodeQL autobuild error * Implement revision suggestions * Add missed test case parameter * PatientIdPartitionIntercepto should allow Encounter.subject parameter (#7348) * Work on megascale enhancements part 6 * Add changelog * Test fix * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7348-allow-patientidcompartmentmode-search-encounter-subject.yaml Co-authored-by: Nathan Doef <[email protected]> * Test fixes --------- Co-authored-by: Nathan Doef <[email protected]> * Bump to spring62 (#7351) * Bump spring framework version * Replace Base64Utils with Base64.getEncoder() * Bump spring boot test deps to match spring version 6.2 * Bump junit for spring tests --------- Co-authored-by: Gary <[email protected]> * 7217 with rel 8 6 (#7337) * Automated Migration Testing (HAPI-FHIR) - updated test migration scripts for 8_6_0 (#7357) * Remove dead autowire (#7365) * Don't reuse TransactionDetails for partitioned TX execution (#7363) * Fix tags on megascale * Add test * Test fix * Version bump --------- Co-authored-by: jdar <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: James Agnew <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]>
jamesagnew
added a commit
that referenced
this pull request
Dec 4, 2025
* Work on bulk update * Add bulk patch partitioning * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Check for null before removing 'max' parameter (#7242) * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * Mergeback 1 rel 8 6 (#7360) * increase memory to elastic search container (#7326) Co-authored-by: jdar <[email protected]> * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown (#7303) * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown. * Enhanced the solution based on code review feedback. * Removed a class that was being used to store the Http response Code and used the existing HttpStatus class instead. * Enhanced the Unit Test. * Enhanced the Javadoc for the Pointcut.SERVER_OUTGOING_FAILURE_OPERATIONOUTCOME enum. * Changed the Interceptor Hook implementation based on Code Review feedback. * Removed an unused variable declaration. * Removed an unused variable declaration. * Ran mvn spotless:apply to apply proper formatting. * More code review feedback. * Use ResponseDetails for exception outcome modification. * Remove bit about "valid status" -- we allow anything * changelog * Replace the response object --------- Co-authored-by: Michael Buckley <[email protected]> * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) (#7327) * Improve URL processing for JpaPersistedResourceValidationSupport (#7330) * Improve URL processing for JpaPersistedResourceValidationSupport * Add changelog * allow fetching subsequent pages when registering an allowed spec of r… (#7329) * allow fetching subsequent pages when registering an allowed spec of resourcetype search * 7833: add missing relationship between TermConcept and TermConceptProperty (#7346) * 7316 do not expand chain refparams (#7350) * Make sure refparams with chains are not expanded via MDM * 7316: code review feedback * [7269] bulk export history fails with client-assigned string IDs (#7300) * fixed 7269 bulk export history failure with client-assigned string IDs * fixed 7269 bulk export history failure with client-assigned string IDs * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml Co-authored-by: jdar8 <[email protected]> * changed string ids to IResourcePersistentId * changed string ids to IResourcePersistentId * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java Co-authored-by: Michael Buckley <[email protected]> * fixed with spotless * Revert "Bump to 8 7 (#7322)" This reverts commit 40f1128. * Revert "changed string ids to IResourcePersistentId" This reverts commit 06af86a. * Revert "batch2 jobs that are cancelled will not be returned when requesting a… (#7321)" This reverts commit be08680. * changed string ids to IResourcePersistentId * fixed with spotless * Bumped version number * adding missing change to fix build --------- Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jdar8 <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Michael Buckley <[email protected]> * [7332] fix mdm-query-links (#7356) * 7324 unable to access collection bundles when performing search requests (#7325) * Add failing tests * Fix * Changelog * Fix comment * Fix test * Try fixing CodeQL autobuild error * Implement revision suggestions * Add missed test case parameter * PatientIdPartitionIntercepto should allow Encounter.subject parameter (#7348) * Work on megascale enhancements part 6 * Add changelog * Test fix * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7348-allow-patientidcompartmentmode-search-encounter-subject.yaml Co-authored-by: Nathan Doef <[email protected]> * Test fixes --------- Co-authored-by: Nathan Doef <[email protected]> * Bump to spring62 (#7351) * Bump spring framework version * Replace Base64Utils with Base64.getEncoder() * Bump spring boot test deps to match spring version 6.2 * Bump junit for spring tests --------- Co-authored-by: Gary <[email protected]> * 7217 with rel 8 6 (#7337) * Automated Migration Testing (HAPI-FHIR) - updated test migration scripts for 8_6_0 (#7357) * Remove dead autowire (#7365) * Don't reuse TransactionDetails for partitioned TX execution (#7363) * Fix tags on megascale * Add test * Test fix * Version bump --------- Co-authored-by: jdar <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: James Agnew <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]> * Ensure streaming queries don't have limit clauses (#7382) * Ensure streaming queries don't impose limit clauses on the sql when called in "synchronous" mode. * changelog * update search docs for accuracy (#7383) Co-authored-by: Elie Maamari <[email protected]> * Add debug logging to migrator. (#7381) * 7386 icd10cmloader is not creating required extensions for concepts (#7392) * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). --------- Co-authored-by: Ian Marshall <[email protected]> * 7385 fix 401 unauthorized response does not include operation outcome (#7389) * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - failing test * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - implementation * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - changelog * Mergeback rel 8 4 1 (#7398) * backport complete * Be more resilient to unexpected resource version IDs in database (#7216) * Handle mismatched versions * Be more resilient to unexpected resource versions in DB * Test fix * Test fix * Work on tests * Test fixes * Test fixes * Add changelog * Spotless * Address review comments * HAPI bump * Fix API breakages * api breakages * version set * changelog and versioning --------- Co-authored-by: James Agnew <[email protected]> Co-authored-by: Gary Graham <[email protected]> Co-authored-by: jdar <[email protected]> * STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails (#7340) * STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails * Add changelog --------- Co-authored-by: James Agnew <[email protected]> * 7217 with rel 8 6 (#7337) * Fix Encounter $everything not working in REQUEST_TENANT partitioning (#7388) * Fix Encounter $everything not working in REQUEST_TENANT partitioning * Add test * changelog * Remove unused HttpServletRequest parameter * Remove unnecessary overriding * bump hapi * bump hapi * versioning * Cleanup * Work on tests * Work on test fixes, about to add TX api for megascale tx service * Get patch working on megascale * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * Test fix * Test fixes * Spotless * Build fixes * Add troubleshooting logging * Add troubleshooting logs * Add troubleshooting * Test fixes * Add changelog * Fix build * Address review comments * Address review comments * Test fixes * Make fetch ranges step dependencies explicit --------- Co-authored-by: jdar8 <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Jens Kristian Villadsen <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]> Co-authored-by: emas12321 <[email protected]> Co-authored-by: Elie Maamari <[email protected]> Co-authored-by: IanMMarshall <[email protected]> Co-authored-by: Ian Marshall <[email protected]> Co-authored-by: elavy-harris <[email protected]>
tadgh
added a commit
that referenced
this pull request
Jan 8, 2026
* Work on bulk update * Add bulk patch partitioning * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Check for null before removing 'max' parameter (#7242) * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * Mergeback 1 rel 8 6 (#7360) * increase memory to elastic search container (#7326) Co-authored-by: jdar <[email protected]> * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown (#7303) * 7282 - Added the ability for an Interceptor to alter the HTTP Response Code when an Exception is thrown. * Enhanced the solution based on code review feedback. * Removed a class that was being used to store the Http response Code and used the existing HttpStatus class instead. * Enhanced the Unit Test. * Enhanced the Javadoc for the Pointcut.SERVER_OUTGOING_FAILURE_OPERATIONOUTCOME enum. * Changed the Interceptor Hook implementation based on Code Review feedback. * Removed an unused variable declaration. * Removed an unused variable declaration. * Ran mvn spotless:apply to apply proper formatting. * More code review feedback. * Use ResponseDetails for exception outcome modification. * Remove bit about "valid status" -- we allow anything * changelog * Replace the response object --------- Co-authored-by: Michael Buckley <[email protected]> * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) (#7327) * Improve URL processing for JpaPersistedResourceValidationSupport (#7330) * Improve URL processing for JpaPersistedResourceValidationSupport * Add changelog * allow fetching subsequent pages when registering an allowed spec of r… (#7329) * allow fetching subsequent pages when registering an allowed spec of resourcetype search * 7833: add missing relationship between TermConcept and TermConceptProperty (#7346) * 7316 do not expand chain refparams (#7350) * Make sure refparams with chains are not expanded via MDM * 7316: code review feedback * [7269] bulk export history fails with client-assigned string IDs (#7300) * fixed 7269 bulk export history failure with client-assigned string IDs * fixed 7269 bulk export history failure with client-assigned string IDs * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7296-bulk-export-fails-with-string-resource-ids.yaml Co-authored-by: jdar8 <[email protected]> * changed string ids to IResourcePersistentId * changed string ids to IResourcePersistentId * batch2 jobs that are cancelled will not be returned when requesting a… (#7321) * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * Update hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/dao/index/IdHelperService.java Co-authored-by: Michael Buckley <[email protected]> * fixed with spotless * Revert "Bump to 8 7 (#7322)" This reverts commit 40f1128. * Revert "changed string ids to IResourcePersistentId" This reverts commit 06af86a. * Revert "batch2 jobs that are cancelled will not be returned when requesting a… (#7321)" This reverts commit be08680. * changed string ids to IResourcePersistentId * fixed with spotless * Bumped version number * adding missing change to fix build --------- Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jdar8 <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Michael Buckley <[email protected]> * [7332] fix mdm-query-links (#7356) * 7324 unable to access collection bundles when performing search requests (#7325) * Add failing tests * Fix * Changelog * Fix comment * Fix test * Try fixing CodeQL autobuild error * Implement revision suggestions * Add missed test case parameter * PatientIdPartitionIntercepto should allow Encounter.subject parameter (#7348) * Work on megascale enhancements part 6 * Add changelog * Test fix * Update hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_6_0/7348-allow-patientidcompartmentmode-search-encounter-subject.yaml Co-authored-by: Nathan Doef <[email protected]> * Test fixes --------- Co-authored-by: Nathan Doef <[email protected]> * Bump to spring62 (#7351) * Bump spring framework version * Replace Base64Utils with Base64.getEncoder() * Bump spring boot test deps to match spring version 6.2 * Bump junit for spring tests --------- Co-authored-by: Gary <[email protected]> * 7217 with rel 8 6 (#7337) * Automated Migration Testing (HAPI-FHIR) - updated test migration scripts for 8_6_0 (#7357) * Remove dead autowire (#7365) * Don't reuse TransactionDetails for partitioned TX execution (#7363) * Fix tags on megascale * Add test * Test fix * Version bump --------- Co-authored-by: jdar <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: James Agnew <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]> * Ensure streaming queries don't have limit clauses (#7382) * Ensure streaming queries don't impose limit clauses on the sql when called in "synchronous" mode. * changelog * update search docs for accuracy (#7383) Co-authored-by: Elie Maamari <[email protected]> * Add debug logging to migrator. (#7381) * 7386 icd10cmloader is not creating required extensions for concepts (#7392) * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). * Fix logic in Icd10CmLoader to append 7th character extensions to the leaf-level concepts in the hierarchy (rather than to just the immediate child concepts). --------- Co-authored-by: Ian Marshall <[email protected]> * 7385 fix 401 unauthorized response does not include operation outcome (#7389) * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - failing test * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - implementation * Inferno test parsing failure when 401 rejection does not contain OperationOutcome - changelog * Mergeback rel 8 4 1 (#7398) * backport complete * Be more resilient to unexpected resource version IDs in database (#7216) * Handle mismatched versions * Be more resilient to unexpected resource versions in DB * Test fix * Test fix * Work on tests * Test fixes * Test fixes * Add changelog * Spotless * Address review comments * HAPI bump * Fix API breakages * api breakages * version set * changelog and versioning --------- Co-authored-by: James Agnew <[email protected]> Co-authored-by: Gary Graham <[email protected]> Co-authored-by: jdar <[email protected]> * STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails (#7340) * STORAGE_TRANSACTION_PROCESSING-doesn't-pass-ServletRequestDetails * Add changelog --------- Co-authored-by: James Agnew <[email protected]> * 7217 with rel 8 6 (#7337) * Fix Encounter $everything not working in REQUEST_TENANT partitioning (#7388) * Fix Encounter $everything not working in REQUEST_TENANT partitioning * Add test * changelog * Remove unused HttpServletRequest parameter * Remove unnecessary overriding * bump hapi * bump hapi * versioning * Cleanup * Work on tests * Work on test fixes, about to add TX api for megascale tx service * Get patch working on megascale * Bump to 8 7 (#7322) * bump to 8.7, add version enums * changelog folder for 8.8 * increase memory to elastic search container --------- Co-authored-by: jdar <[email protected]> * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * [7332] Fix $mdm-query-links in partition mode (#7333) * [7332] update mdm resource persistence id * [7332] add tests and changelog * [7332] update changelog * [7332] update test * [7332] update test * [7332] update changelog * Test fix * Test fixes * Spotless * Build fixes * Add troubleshooting logging * Add troubleshooting logs * Add troubleshooting * Test fixes * Add changelog * Fix build * Address review comments * Address review comments * Test fixes * Make fetch ranges step dependencies explicit --------- Co-authored-by: jdar8 <[email protected]> Co-authored-by: jdar <[email protected]> Co-authored-by: Jens Kristian Villadsen <[email protected]> Co-authored-by: Yaling Pei <[email protected]> Co-authored-by: Kevin Dougan <[email protected]> Co-authored-by: Michael Buckley <[email protected]> Co-authored-by: TipzCM <[email protected]> Co-authored-by: another-luis <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: Rob Caruso <[email protected]> Co-authored-by: jmarchionatto <[email protected]> Co-authored-by: Nathan Doef <[email protected]> Co-authored-by: tadgh <[email protected]> Co-authored-by: Gary <[email protected]> Co-authored-by: volodymyr-korzh <[email protected]> Co-authored-by: Gary Graham <[email protected]> Co-authored-by: emas12321 <[email protected]> Co-authored-by: Elie Maamari <[email protected]> Co-authored-by: IanMMarshall <[email protected]> Co-authored-by: Ian Marshall <[email protected]> Co-authored-by: elavy-harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bulk export with
_includeHistory=truefails to export history records for resources that have client-assigned string IDs (forced IDs). The exportcompletes successfully but history versions are missing from the output for any resources with client-assigned IDs.
Cause
When performing a bulk export with history enabled, the
processHistoryResources()method was converting resource PIDs to their forced ID strings viaconvertToStringIds()before querying for history. However, history records in the database are indexed by numeric PIDs, not forced IDs. This causesthe history query (
IBulkDataExportHistoryHelper.fetchHistoryForResourceIds()) to return no results for resources with client-assigned IDs.Fix
Modified
ExpandResourceAndWriteBinaryStep.processHistoryResources()(line 225) to use numeric PIDs directly by callingtypePidJsonList.stream().map(TypedPidJson::getPid).toList()instead ofconvertToStringIds(). The bulk export history helper can work with PIDsnatively, making the forced ID conversion unnecessary and incorrect for history queries.
Added test
testSystemBulkExportWithHistory_WithClientAssignedIds()that validates all history versions are exported for resources with forced IDs.Closes #7296